vtil-project / VTIL-Core

Virtual-machine Translation Intermediate Language

BSD 3-Clause "New" or "Revised" License

1.31k stars 165 forks source link

Fix test_access #62

Closed wallds closed 2 years ago

wallds commented 2 years ago

about

https://discord.com/channels/724300992023232533/724322269870030958/929826019588837427

for test

auto rtn = vtil::load_routine("./000000000011D902.optimized.vtil");
vtil::logger::log("Before:\n");
vtil::debug::dump(rtn);
vtil::optimizer::apply_all(rtn);
vtil::logger::log("After:\n");
vtil::debug::dump(rtn);

vtil file

000000000011D902.optimized.vtil.zip

000000000008F250.optimized.vtil.zip

before

after

mrexodia commented 2 years ago

I rebased your branch on latest master that uses GH actions

wallds commented 2 years ago

This is the reason why the test case "Simplification" did not pass

https://github.com/vtil-project/VTIL-Core/blob/70d5121b5d85ca591b7e9cac6cda5e8bb4aa651f/VTIL-Tests/dummy.cpp#L278

Solution

ignore cc.shadow_space in the case of ins::vexit. Or actually ins::vexit should use preserve_all_convention?

mrexodia commented 2 years ago

Thanks!