search

vtil-project / VTIL-Core

Virtual-machine Translation Intermediate Language
BSD 3-Clause "New" or "Revised" License
1.31k stars 165 forks source link

Force x86-64 on MacOS #68

Closed Acurisu closed 2 years ago

Acurisu commented 2 years ago

This would allow people to build VTIL on Apple Silicon. It requires Rosetta 2 and a CMake that supports x86-64 but everything else should be normal.

mrexodia commented 2 years ago

Hi,

Thanks for your contribution! Unfortunately this would also restrict VTIL to only compile as x86. Perhaps it would be better to add this as a note in the readme?

Duncan

Acurisu commented 2 years ago

Yes this is true, however at the moment VTIL doesn't compile for ARM (on MacOS) so I don't see this restriction as bad. If VTIL however should compile as ARM then this has been a misunderstanding on my part and it should ofcourse be fixed correctly.

mrexodia commented 2 years ago

No, it doesn’t compile on ARM (or at least I didn’t try since I don’t own an M1 device). Setting variables prefixed with CMAKE_ is a job for the toolchain or the user via command line though.

Acurisu commented 2 years ago

My bad, I thought it would be okay in this case. I will add a note to the README.

Acurisu commented 2 years ago

I reverted the change and added the note. I hope this is okay now.

mrexodia commented 2 years ago

Thank you!