search

vtjeng / MIPVerify.jl

Evaluating Robustness of Neural Networks with Mixed Integer Programming
MIT License
113 stars 31 forks source link

Change direct access of `.lo` and `.hi` fields to function calls to `inf` and `sup`. #147

Closed vtjeng closed 9 months ago

vtjeng commented 9 months ago

This PR is expected to be a no-op.

Motivation

This is necessary since the .hi field appears to be no longer available in 0.22: https://github.com/vtjeng/MIPVerify.jl/pull/146#issuecomment-1855248801

Testing

inf and sup have been available in the IntervalArithmetic.jl package since 0.15, which is the earliest version of IntervalArithmetic.jl our package supports: https://github.com/JuliaIntervals/IntervalArithmetic.jl/blob/e19764302e41c1b619b2a50727586be4ff90b6c7/src/IntervalArithmetic.jl#L55.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b0ebe49) 91.42% compared to head (041684c) 91.42%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #147 +/- ## ======================================= Coverage 91.42% 91.42% ======================================= Files 25 25 Lines 816 816 ======================================= Hits 746 746 Misses 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.