[WIP] Add globstar support

vtjnash / Glob.jl

Posix-compliant file name pattern matching

Other

126 stars 18 forks source link

[WIP] Add globstar support #21

Closed oxinabox closed 5 years ago

oxinabox commented 5 years ago

Closes #19

Right now this is attached to the x extended flag on FilenameMatch, I do not know how to hook it to glob

coveralls commented 5 years ago

Coverage decreased (-13.0%) to 79.63% when pulling 1e4609f368271f2becf7be9395cca69330048d33 on oxinabox:ox/globstar into ed18d97946ea458eb235d1d963d368120358fa89 on vtjnash:master.

vtjnash commented 5 years ago

This can't actually be hooked up to glob, since that actually will need a different (glob) algorithm to implement it (this doesn't close #19) and doesn't need any changes to fnmatch.

Since this doesn't appear to be in posix or gnu (and isn't actually relevant for globstar), I'm inclined to say no here, if that's OK with you.

oxinabox commented 5 years ago

Saying no to this PR, I am down with. I wasn't sure it was right to begin with and that was kinda why I openned it still WIP.

Saying no to #19 is giving up on one of the most useful features of bash's Glob that I miss all the time

schneiderfelipe commented 3 years ago

@vtjnash @oxinabox Couldn't this be implemented as a separate macro/function or requiring a flag? This way, the defaults would still comply with POSIX. This is really useful.

vtjnash commented 3 years ago

The problem is that this PR doesn't really do anything useful, not that the concept (#19) is not useful. The implementation is required is just very different than this.