search

vtorri / ewpi

EFL Windows package installer
GNU General Public License v2.0
12 stars 7 forks source link

Packages no longer build on Linux after verbose option commit #15

Closed Stefan-Schmidt closed 4 years ago

Stefan-Schmidt commented 5 years ago

Since the verbose option was added already the first package (pkg-config) fails to build with this in make.log:

make: *** No rule to make target 'no'. Stop.

Somehow the "no" option was put in as a make target. I do not have --verbose defined on my commandline.

Reverting the verbose option commit (237283e679e0eb7cf41f045710f9a5b3f36fea6b) brings ewpi back to a working state for me.

vtorri commented 5 years ago

i've commit a fix which works for Ubuntu 18.04 LTS

Stefan-Schmidt commented 5 years ago

The problem is still there. I just found out it only shows when no --jobs argument is set. If you give the jobs number to ewpi it will happily work.

Seems like something got wrong with passing the args from ewpi to the instal.sh scripts when you added the verbose option.

vtorri commented 5 years ago

ha. I don't have this problem, but ok, it's the beginning of something i can investigate. thank you

vtorri commented 5 years ago

so config.log is correctly filled, right ?

vtorri commented 5 years ago

can you try this (all in git repo) : in ewpi/common.sh : replace verbmake="V=1" and verbmake="V=0" with respectively : verbmake="1" and verbmake="0"

and in pkgconfig/install.sh, replace $verbmake with V=$verbmake

vtorri commented 5 years ago

or :

make -j $5 $verbmake with make -j$5 $verbmake

or with : make $verbmake -j $5

Stefan-Schmidt commented 5 years ago

The problem really is here that $5 is "no" when no --jobs option is given. (I echoed it from the install.sh script)

Make will interpret this as -j (valid as option without argument) and then the target "no".

Which means the handling of the -j option is wrong in ewpi. If none is given it should pass an empty string and if a number is given it should pass the job number as integer.

vtorri commented 4 years ago

is it fixed now ?

Stefan-Schmidt commented 4 years ago

I just run another fresh build from HEAD (f887af697de0d77df7806ea01bc3011cfe0bb929) and I see the make: *** No rule to make target 'no'. Stop. problem in the libsnappy package.

The rest seems to work now

Stefan-Schmidt commented 4 years ago

And just to be clear. If I run this with --jobs=2 for example it works fine

vtorri commented 4 years ago

and now ?

Stefan-Schmidt commented 4 years ago

With todays HEAD I am not seeing this issue anymore