search

vtos / moodle-mod_adaptivequiz

CAT (Computer-Adaptive Testing) implementation for Moodle LMS (https://moodle.org): officially supported plugin.
https://moodle.org/plugins/mod_adaptivequiz
5 stars 9 forks source link

Integrate catmodel subplugins with mod form reload #29

Closed davidszkiba closed 8 months ago

davidszkiba commented 9 months ago

Hi Vitaly,

I'm creating this PR to integrate the catmodel subplugin changes.

Before creating this PR, I did the following:

davidszkiba commented 9 months ago

@vtos Hi Vitaly! I've just merged branch MOODLE_402 into this PR branch to resolve some merge conflicts. Could you please take a look and tell me if it looks ok to you? Thanks

vtos commented 9 months ago

@davidszkiba Hi David, thanks for the PR, however, I was a bit puzzled by it. I mean, I was planning to integrate all these additions to the plugin myself at some point. The issue is I first had to release the versions which make the plugin compatible with the latest Moodle (4.1.4-4.2, supporting 4.3 is on the way). There were some issues in the plugin which are not used by you, as they're related to the default algorithm and reporting. Now I'm preparing a release for Moodle 4.3. After this, I'll integrate all the sub-plugins additions in the next version. We should always keep in mind, that the plugin is widely used without any sub-plugins and we must ensure the default functionality is not broken with those additions. That's why integrating of those additions may be slower than you wanted it to be ;) Anyway, I'm currently allocating good amount of time to work on the plugin, so don't worry, we'll be fine. We can keep this PR open, no problem. Cheers!

davidszkiba commented 9 months ago

@vtos Hi Vitaly, Ok, I understand. And you're right, I thought by creating the PR and rebasing it, it would be easier and quicker for you to integrate. Since you made all these additions, you know better how to update the codebase and resolve any conflicts. However, maybe you can re-use these commits if it helps: c0785de a22a830 I'm not sure how much else you can re-use from this PR, so feel free to close it. Please let me know if I can help you somehow with this.

Thanks!