vtos / moodle-mod_adaptivequiz

CAT (Computer-Adaptive Testing) implementation for Moodle LMS (https://moodle.org): officially supported plugin.
https://moodle.org/plugins/mod_adaptivequiz
5 stars 9 forks source link

Capabilities for viewing by non-editing teacher #37

Open 0815-xyz opened 5 months ago

0815-xyz commented 5 months ago

Hi, it's not directly a bug but just an improvement suggestion for the attempt review feature that would increase the usability for so-called non-editing teachers.

I'd suggest to add the following two capabilities for the role "teacher" (they are currently enabled only for "editing teacher") since viewing these is necessary for all teachers. For comparison I have shown the corresponding capability in the standard quiz.

There should be no reason to not just add the line _'teacher' => CAPALLOW, in the access.php for:

1) mod/adaptivequiz:viewreport

2) mod/adaptivequiz:reviewattempts image In the Moodle standard quiz there is no capability "reviewattempts" but the attempt review by teachers is controlled by mod/quiz:viewreports. (There is only mod/quiz:reviewmyattempts for a student to review their own previous attempts.)

vtos commented 5 months ago

Hi @0815-xyz

As far I see, you basically want to allow a certain capability to the role you want on the role settings page. But are you saying it's necessary to have it defined in the plugin's capabilities definition, so this cap is set by default when doing a fresh install?

0815-xyz commented 5 months ago

Hi @vtos ,

Yes, that's what I mean. Of course everyone can always change the role capabilities in their own Moodle instance and in our setup we have already done that. But because it makes sense in general that a teacher is able to review attempts and view reports, I thought that it would be appropriate to make it a plugin default, if you don't mind.

vtos commented 5 months ago

@0815-xyz that makes sense, don't see why it cannot be implemented or any implications for the users. Can be included in the next release.