search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

Update AcknowListSwiftUIView to support link to repository URL #106

Closed vtourraine closed 1 year ago

HenryGlendening commented 1 year ago

@vtourraine Awesome, thanks for the quick reply! This is working really great for me on iOS.

For tvOS, when I select a row however, nothing happens. Since on iOS it opens the GitHub page in Safari, I'm wondering if that's the problem with tvOS since it doesn't support webviews? I'd take a deeper look but don't have more time at the moment. This is my first project using SPM so I'm not super familiar, but if that is what's happening, I'm wondering if there's a way the License file can be read and displayed on the tvOS platform.

vtourraine commented 1 year ago

Fantastic, thank you for the confirmation for iOS.

As for tvOS, you’re right, there’s no way to display a web page, and unfortunately SPM dependencies are not explicitly attached to a licence. We could try something more complex, like trying to guess the path of the licence file from the repo URL, fetch it, and display it. Maybe for a future update?

HenryGlendening commented 1 year ago

@vtourraine Ah, I see what you mean. And yea, that solution could work. I agree that it'd be more fitting for a future update, since it's less of a patch and more of a feature at this point.

Thanks again for the quick fix on the iOS platform!