Get missing licenses from GitHub API

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.

MIT License

784 stars 59 forks source link

Get missing licenses from GitHub API #113

Closed vtourraine closed 9 months ago

vtourraine commented 9 months ago

Add GitHubAPI to get licenses from GitHub API
Update AcknowListViewController to get missing licenses from GitHub API, with new canFetchLicenseFromGitHub property to disable this behavior

mischa-hildebrand commented 8 months ago

@vtourraine Nice, thank you! Note that the functionality to fetch the LICENSE files from the GitHub repos is only implemented for UIKit so far (on the AcknowListViewController). The SwiftUI view doesn't support this yet and still opens the repo's main page in Safari. Would probably make sense to extract this logic from the view and reuse it.

vtourraine commented 8 months ago

@mischa-hildebrand Thank you for the feedback! I’ve just opened a pull request adding support for SwiftUI: #116. Feel free to test it, and let me know if you have any suggestions.