search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
784 stars 59 forks source link

Unable to make it work with SwiftUI on macOS #114

Closed bourquep closed 8 months ago

bourquep commented 9 months ago

I instantiate the view like this:

NavigationView {
  AcknowListSwiftUIView(acknowList: AcknowParser.defaultPackages()!)
}

And I get this result:

CleanShot 2023-12-23 at 10 37 08@2x

Clicking on the buttons does nothing.

vtourraine commented 8 months ago

Thank you for reporting this!

I’ll try to investigate, but feel free to submit a pull request if you manage to fix it.

vtourraine commented 8 months ago

@bourquep I have opened a pull request that should fix your problem: #115

Could you please test it, and confirm the links open? (I know that doesn’t improve the interface, which is quite poor at the moment on macOS with SwiftUI, but that will be a different pull request.) Thank you in advance!

bourquep commented 8 months ago

@vtourraine I am no longer setup to test this, as I've moved to another library, but I'll give it a shot soon and get back to you!

vtourraine commented 8 months ago

@bourquep Thanks for the update, I’m looking forward to your feedback. 👍