Possibility to provide own localization

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.

MIT License

807 stars 60 forks source link

Possibility to provide own localization #15

Closed orschaef closed 8 years ago

orschaef commented 8 years ago

The latest AcknowList update changed my navigationItem title to "Danksagungen" for German localization. This translation is not completely wrong but you would often use another word (like "Lizenzen" what equals "licences")

I would prefer to provide my own localization.

Suggestions:

Give possibility to ship a custom .strings file or
Provide public properties to set the title

vtourraine commented 8 years ago

That’s a totally legitimate request, and I think you just need to update the title property (inherited from UIViewController).

orschaef commented 8 years ago

Well, yes ... thats ok for this certain case. It was too obvious ;) But maybe it makes sense to provide certain properties or any functionality to solve this better in the future?

vtourraine commented 8 years ago

Glad to hear that it works.

I’d be happy to improve this use-case, but I don’t want to duplicate an existing property. Do you have any suggestion on how to better address this issue? Maybe we should simply mention this possibility in the readme?

orschaef commented 8 years ago

Sorry for the late response.

Right at the moment I have no better idea. Let's close the issue for now. If I come around with THE SOLUTION™ I'll contact you again ;-)