search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
807 stars 60 forks source link

Make @IBInspectable variables public #16

Closed BasThomas closed 8 years ago

BasThomas commented 8 years ago

They can be set directly from code, now.

vtourraine commented 8 years ago

I'm really sorry about this super-late reply, but thanks for the pull request!

It makes total sense to have public header and footer properties. I'm not so sure about acknowledgementsPlistName, though, because if you load the acknowledgements programmatically, you should use the initializers instead.

BasThomas commented 8 years ago

Better late than never! ☺️ I think you are right about the acknowledgementsPlistName though; it doesn't make sense to set this later. Should I make another PR?

BasThomas commented 8 years ago

Also, if you can update the version number of the pod afterwards, that'd be great!

vtourraine commented 8 years ago

If you have 2 more minutes to spare, go head. Otherwise I'll edit it.

vtourraine commented 8 years ago

I was waiting for the Xcode 8 official release to push a new version, but it might be useful to push a new minor version before, for people who keep using Xcode 7 for now.

BasThomas commented 8 years ago

Yeah, a minor version update to fix this would be great.

vtourraine commented 8 years ago

There you go. I've reverted the change on acknowledgementsPlistName, and pushed version 1.0.1.

Thanks once again for the pull request. 👍