Add license types support

[naoty]

I added a feature which adds license types to acknowledgements.plist to CocoaPods (https://github.com/CocoaPods/CocoaPods/pull/5436). From 1.1.0.beta.1, the license type of each acknowledgements can be used. So, I want to filter acknowledgements by using this feature.

[vtourraine]

Sorry about this late reply, and thanks for sending the pull request!

This new "type" property is very interesting, so we should definitely update the Acknow class to handle it.

At the same time, I want to keep the general interface for this pod as straightforward as possible, and I think that filtering acknowledgements by type is a very specific use case. Could you revert the changes on the AcknowListViewController initializers? Once this pod supports the type property, everyone will be able to filter/combine/edit the acknowledgements accordingly in their own code. What do you think?

[naoty]

@vtourraine Thank you for reply. I'm sorry for late reply, too. I'm totally agree with your idea. I will remove AcknowListViewController initializers.

I use this library in Swift 2.3. Which branch should I send this pull request?

[vtourraine]

Great, thanks for the follow-up! 👍

I’ve added a new swift-2-3 branch, you can send your pull request there. Feel free to send another pull request for Swift 3 to master, otherwise I’ll just migrate it myself, to make it available to everyone going forward.

[naoty]

@vtourraine I changed the base branch to swift-2.3 and reverted AcknowListViewController initializers.

[vtourraine]

Thanks so much for the update, I’m merging it in right now. 👍

[vtourraine]

I’ve now also ported these changes for Swift 3 on master (code is basically the same): cc04b7ffb9581db40eab2e18d8b9f56f738f30d4

[naoty]

@vtourraine Thank you for merging!