search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

'Acknow' initializer is inaccessible due to 'internal' protection level #30

Closed klwoon closed 7 years ago

klwoon commented 7 years ago

let ack = Acknow(title: "ABC", text: "ABC", license: "ABC") gives the error:

'Acknow' initializer is inaccessible due to 'internal' protection level

Using v1.2

klwoon commented 7 years ago

I just check the Acknow.swift under Pod folder, it's different with your latest commit in master branch.

vtourraine commented 7 years ago

That’s... interesting. And if you manually update Acknow.swift to the latest version (1.2 or master), does it compile?

klwoon commented 7 years ago

If point to master branch then no more compilation error: pod 'AcknowList', :git => 'git@github.com:vtourraine/AcknowList.git', :branch => 'master'

Could it be the podspec is referring to an older version? (I'm no cocoapods expert)

vtourraine commented 7 years ago

I just checked, and you’re right, the last CocoaPods version isn’t pointing at the latest code changes. This might be related to the new Swift/Xcode version, and how default initializers get exposed now, but anyway, I should definitely update the CocoaPods configuration and push a new version to fix this issue. I’ll take care of this later today.

Thank you so much for the feedback! 👍

klwoon commented 7 years ago

Thanks for the great work!

vtourraine commented 7 years ago

ℹ️ Released version 1.2.1 on CocoaPods