tvOS support - Githubissues

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.

MIT License

798 stars 60 forks source link

tvOS support #35

Closed honkmaster closed 6 years ago

honkmaster commented 6 years ago

Hi,

I was trying to use AcknowList with tvOS, similar to VTAcknowledgementsViewController. However, it does not work :):

[!] The platform of the target `redacted` (tvOS 11.0) is not compatible with `AcknowList (1.5)`, which does not support `tvos`.

Is this just a CocoaPods or a repository/source issue?

Best

vtourraine commented 6 years ago

Hello! No, I never got around to add tvOS support. But I just saw your branch and so... now I’m looking forward to your pull request :smile:

honkmaster commented 6 years ago

Check.

honkmaster commented 6 years ago

Quick question: The minimum OS version is 8.0, right? Thus, I would replace UIFont.systemFont(ofSize: 12) with UIFont.preferredFont(forTextStyle: .footnote).

honkmaster commented 6 years ago

Could you please create a new release for Cocoapods?

vtourraine commented 6 years ago

@honkmaster Just released version 1.6 with tvOS support on CocoaPods. 🚀

honkmaster commented 6 years ago

🍻