vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

Licenses do not show up in AcknowListViewController #40

Closed agisilaos closed 6 years ago

agisilaos commented 6 years ago

Hello 👋 I'm trying to show the licenses of OSS libraries I use on my project using AcknowList and I can't. I followed every step on the README. I'm using version 1.2.1 of AcknowList since many of the pods I'm using aren't migrated to 4.0.

1. I moved the appropriate file as a reference into my project:

screen shot 2018-07-12 at 00 03 16

2. I created the VC etc

        if indexPath.section == 2 {
            switch indexPath.row {
            case 0:
                let viewController = AcknowListViewController()
                navigationController?.pushViewController(viewController, animated: true)
            default:
                break
            }
        }

3. When I land on the screen I get this as a result:

screen shot 2018-07-12 at 00 10 57

and I get that as an error message:

** AcknowList Warning **
No acknowledgments found.
This probably means that you didn’t import the `Pods-acknowledgements.plist` to your main target.

I really can't understand why I get this error since I followed every step on the README. 🤔

Any ideas what may be wrong would be more than appreciated.

Notes:

cc: @vtourraine

agisilaos commented 6 years ago

After messing around with it more, I had to rename Pods-Iris-acknowledgements.plist to Pods-acknowledgements.plist. This isn't documented on the README though, or it wasn't obvious more me at least. I will try to make a PR updating the docs and make the steps more clear. 😍