search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

Text spacing bug on iPads #41

Closed azhang66 closed 6 years ago

azhang66 commented 6 years ago

Following commit cf5c82d, there is an issue displaying certain acknowledgements on iPads. With the exception of AcknowList's own license, all of my Pods are affected by this issue (see below pictures for an example with Alamofire). This did not occur in v1.6.0, so I believe it is a regression caused by cf5c82d.

EDIT: cf5c82d turned out to not be the problem. The problem was actually due to premature newlines. I've written a PR to fix this here: #43

acknowlist correct alamofire incorrect
azhang66 commented 6 years ago

Did some more testing and it's not a regression. Sorry about that! Turned out to be an issue with licenses containing premature line breaks. I wrote a pull request to fix this here: #42 #43

vtourraine commented 6 years ago

Fixed with #43