search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
784 stars 59 forks source link

Make acknowledgements list and details themable #52

Closed Wooder closed 4 years ago

Wooder commented 5 years ago

This adds some properties to customize colors & fonts the of acknowledgementlist and details view on iOS and tvOS. I've added additional buttons to the existing examples

to show the usage.

iOS-Preview: ios1 ios2

tvOS-Preview: tvOS1 tvOS2

vtourraine commented 5 years ago

Hello Jochen, and thank you for sending the pull request!

Unfortunately, I don’t think I’ll merge it. I understand this level of customization can be useful in some contexts, but for the vast majority of apps, this just adds too much unnecessary complexity. This appreciation is highly subjective, I know, but I always try to keep my open source project as simple as they can be, while keeping the door open to subclassing and any kind of customization.

Wooder commented 5 years ago

Hi Vincent! Thanks for reviewing the PR and your detailed answer.

I think many users would like the feature to make "AcknowList" themable. It's a usual scenario to adapt the fonts & colors of a used UILibrary.

All properties for Colors & Fonts are optional. So the Controller may used as easy as before (nothing to do for existing code). Only folks who want to adapt the colors/fonts to their apps scheme would use this properties for customization.

But anyway - i respect your decision - i will keep it alive as fork.

Wooder commented 4 years ago

I removed it to keep the list of pull request clean.