search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

Support for Xcode 11 Swift package manager? #53

Closed OscarGorog closed 5 years ago

OscarGorog commented 5 years ago

Is there any support coming for Xcode 11's new "Swift Package Manager"?

Thanks

OscarGorog commented 5 years ago

Thanks!

lvnkmn commented 5 years ago

You're welcome. However, even though I've been using it successfully for a bit now, the PR has not been merged yet.. Some action is still needed.

vtourraine commented 5 years ago

Hello, and sorry for my lack of response to the Swift Package Manager issues and pull requests. I just want to learn a bit more about SPM before merging it in, but I intend to do it soon. Thanks for your patience.

tradingstratagem commented 5 years ago

I'm also trying to move all the dependencies to SPM

lvnkmn commented 5 years ago

@tradingstratagem if you don’t like waiting, you van use my fork (the one from the PR mentioned above) it works.

@vtourraine there’s really not much to it, but feel free to do more research 👌

tradingstratagem commented 5 years ago

I can wait a couple of days/weeks, but thanks for the suggestion

vtourraine commented 5 years ago

Good news: I’ve merged the pull request and tagged the changes, so you can now install this library with SPM directly from Xcode.

That being said, we still have a couple of issues with the current implementation (resources, folder structure, unit tests), as summarized here: https://github.com/vtourraine/AcknowList/pull/58#issuecomment-538933567

Please use the dedicated GitHub issues for further discussion. And thank you everybody for contributing!