Extends functionality to figure out the Bundle Name

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.

MIT License

784 stars 59 forks source link

Extends functionality to figure out the Bundle Name #56

Closed fjtrujy closed 5 years ago

fjtrujy commented 5 years ago

Hello, I was trying to use the library and I saw that it wasn't finding the proper plist, even been with the proper name Pods-{MyApp}-acknowledgements. Debugging I saw that the CFBundleName is empty in my App (probably because it is localized), so going deeper I saw that the CFBundleExecutable contains the value that I was looking for.

I have added a new function that by default search the CFBundleName field and if it is empty then go for CFBundleExecutable

Thanks!

vtourraine commented 5 years ago

Hello Francisco, and thanks a lot for the pull request! 👍

I’ve refactored it slightly to align its coding style with the rest of the repo, and now it’s merged.