Improvement with the UITableViewCells

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.

MIT License

784 stars 59 forks source link

Closed fjtrujy closed 5 years ago

fjtrujy commented 5 years ago

Hello, this PR make some improvements in the general use of the UITableVIew & UITableViewCells.

It improves 2 features:

It follows the recommended way by apple to reuse UITableViewCells, it is no longer needed to check if the cell was created previously.
Deselect the cell after being selected, is not needed to thing tricky things in the viewWillAppear method.

Feel free to change/adapt to your guideline style. Finally, remember also to update & release it in Cocoapods.

Thanks

vtourraine commented 5 years ago

Hello Francisco, and thank you so much for sending this pull request!

Changing the cell init method: great 👍
Changing the cell deselect flow: it would make the code cleaner, but the interface a little bit worse, I think. Having the original cell still selected when you pop the controller is a great way to visually link the 2 screens, even if it’s only visible for a split second.

So I’ll merge this in, and revert the second part. I hope that makes sense.