search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
784 stars 59 forks source link

Fix header/footer layout issue #65

Closed plu closed 4 years ago

plu commented 4 years ago

Fixes #64

plu commented 4 years ago
Screenshot 2020-02-05 at 14 54 34 Screenshot 2020-02-05 at 14 54 37 Screenshot 2020-02-05 at 14 55 02 Screenshot 2020-02-05 at 14 55 08 Screenshot 2020-02-05 at 14 55 12
vtourraine commented 4 years ago

Hello @plu 👋

First of all, my sincere apologies for this late reply. And thank you for preparing this pull request.

The way header/footer views are initialized has been slightly refactored, so we’ll need to update this pull request to reflect that and solve the merge conflicts.

More importantly, I appreciate your solution to this problem, but I’m concerned about essentially setting the views from viewWillLayoutSubviews by just dispatching a call on main. Isn’t there a more specific method, from where we could update the header/footer only as needed, without any async dispatching?