search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

Tableview style #70

Closed iDevelopper closed 3 years ago

iDevelopper commented 3 years ago

Hi,

Let choose the style of the table view.

vtourraine commented 3 years ago

Hello Patrick, and thank you for sending this pull request. 👍

As it happens, another pull request got opened last week with the same purpose: #69. So I’ll close this one, and hopefully you’ll get the feature you were looking for soon enough. In the meantime, you’re welcome to comment and contribute to the other pull request. Thanks!

iDevelopper commented 3 years ago

This pull request is different. It does not concern the title, since indeed the title is accessible. But it just allows us to choose the style of the view table and fixes a frame problem in the case of plain.

I know a lot of developers don't like to merge pull requests. Never mind !

Thanks,

vtourraine commented 3 years ago

Well, the other pull request was about 2 things: custom title and custom table view style. We all agree that the title doesn’t need extra implementation, so what’s left is the same idea of adding a “table view style” parameter to the initializers. (I think that’s the first time I get 2 pull requests for the same thing simultaneously 😅)