Tableview style & Storyboard support

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.

MIT License

798 stars 60 forks source link

Tableview style & Storyboard support #71

Closed iDevelopper closed 3 years ago

iDevelopper commented 3 years ago

Hi,

Please reconsider this pull request, thanks!

Let choose the table view style
Fix storyboard support issues (did not work)
Fix footer text layout (if plain, there was no space between the cell and the footer text)

Update example:

Replace UIViewController by UITableViewController in Main.storyboard
Add another one to have a plain one too
Update ViewController example (storyboard & code)

Simulator Screen Shot - iPhone 11 - 2021-01-27 at 09 25 20

vtourraine commented 3 years ago

Hello, and thanks again for preparing this pull request. 👍

As I mentioned on the previous one, there was already an open pull request adding support for custom table view style (“first created, first merged”, I guess). The good news is that it has now been merged. This should address your main concern.

Your pull request also mentions a layout bug. Could you please open a dedicated pull request, based on the latest repo version? Thanks!