vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
784 stars 59 forks source link

Header Label Localization #76

Closed iDevelopper closed 3 years ago

iDevelopper commented 3 years ago

Why the default header label is not localized?

vtourraine commented 3 years ago

Are you referring to This application makes use of the following third party libraries:?

Originally, I found this line a bit redundant with the title of the screen. On some projects, it’s not entirely accurate (it’s not always “third party libraries”). It’s also a bit uncommon to have an introduction text like that at the top of a table view.

So it wasn’t included when we started localizing this library, and I imagine it would be more difficult to add it now. Of course, you can always add it “manually” when your app configures the view controller.

iDevelopper commented 3 years ago

Are you referring to This application makes use of the following third party libraries:?

Yes

And I think about how to modify the code so that it supports the storyboard. Which is not currently the case.

iDevelopper commented 3 years ago

I modified the init but it is not sufficient.

    public required init?(coder aDecoder: NSCoder) {
        //super.init(style: .grouped)
        super.init(coder: aDecoder)
        /*
        let path = AcknowListViewController.defaultAcknowledgementsPlistPath()
        if let path = path {
            commonInit(acknowledgementsPlistPaths: [path])
        }
        else {
            commonInit(acknowledgementsPlistPaths: [])
        }
        */
    }
vtourraine commented 3 years ago

Which is not currently the case.

Ha, that’s a bug then. I’ll look into it, thanks for pointing this out 👍

iDevelopper commented 3 years ago

Which is not currently the case.

The framework does not take into account the texts entered in the IBInspectable fields.

vtourraine commented 3 years ago

@iDevelopper Please check out #78

iDevelopper commented 3 years ago

I think you need to change the initializer code as well. Try to change the background color of the table view in the storyboard, for example.

public required init?(coder aDecoder: NSCoder) {
    super.init(coder: aDecoder)
}