search

vtourraine / AcknowList

Acknowledgements screen displaying a list of licenses, for example from CocoaPods and Swift Package Manager dependencies.
MIT License
798 stars 60 forks source link

Fix header/footer `@IBInspectable` support #78

Closed vtourraine closed 3 years ago

vtourraine commented 3 years ago

As reported by #76

iDevelopper commented 3 years ago

I think you need to change the initializer code as well. Try to change the background color of the table view in the storyboard, for example.

    public required init?(coder aDecoder: NSCoder) {
        super.init(coder: aDecoder)
    }
vtourraine commented 3 years ago

@iDevelopper Thanks for the feedback, I’ll keep working on it.

vtourraine commented 3 years ago

I fixed the initializer as you suggested, and updated the Manual Example project. I think the correct approach is to add a UITableViewController object in Interface Builder and set it as a AcknowListViewController. Then you get the table view properties in the inspector, so you can change not just the background color but also the table view style.

iDevelopper commented 3 years ago

Yes that's it ! Background color was an example. Great!

iDevelopper commented 3 years ago

When do you expect to make all these modifications (WIP) available in Cocoapods?

vtourraine commented 3 years ago

My goal is to release that as a version 2.0, which is a great to allow ourselves to break things and make them better, but at the same time we want to be extra cautious.

So I’m not sure about the timeframe. I think we’re almost done, but I also want to give enough time so that other people have a chance to test this new version.

Let’s say I hope we can release it sometimes next month.

iDevelopper commented 3 years ago

Hello Vincent,

What about a better example. I wrote one in my pull request #71.

What do you think?

vtourraine commented 3 years ago

Your example is definitely more comprehensive. Though, to be honest, I’m not sure how useful it is, compared to the current version which already covers all the main configurations. Adding complexity to the example project implies a maintenance cost, so there has to be a meaningful added-value.

If you really find it useful, you can open a dedicated pull request. I’d be interested to know what other people think of this.