search

vtp5 / vtp5

Vocabulary Testing Program 5, made in Java.
http://vtp5.github.io
7 stars 1 forks source link

Source code is missing in action #138

Open jskeet opened 9 years ago

jskeet commented 9 years ago

(Both in terms of the repository, and the source zip files.)

As my son (at Reading) is going to use VTP5 for homework, I thought I'd have a look at the source code... but there isn't any as far as I can see. (It looks like everything was deleted in commit 280092f5c1d2ee7196a6c7f3379460f1daee3402 but it's not clear why...)

abdelabdalla commented 9 years ago

Hi, Thanks for taking interest in our program. We have recently decided to move the code to a private repository and keep this one open as a platform to release new updates and have a way for people to submit issues. We would be happy to give you acces to the code either by adding you to the private repository or emailing it to you.

jskeet commented 9 years ago

No need to go to any trouble - it was idle curiosity more than anything else. (I'd be happy to do a little code/design critique if you feel that would be useful though.)

I'd urge you to consider going back to open source in the longer term, mind you :)

Will close this issue now.

ymohamedahmed commented 9 years ago

Hi,

We would just like to reiterate that we are very much appreciative of your interest and we would be extremely grateful if you could critique our code. However, at present we are working on implementing a JavaFx GUI and the process of redesign means that the most recent code is currently in development and thus isn't fully functioning. We have now added you to both the JavaFx and the Old repos. Your critique is much appreciated.

Thanks, The VTP5 Team.

ghost commented 8 years ago

Maybe you could take this opportunity to move to a mostly web-based platform. I prefer not to use Java on my machine, and a web-based platform would allow easier usage (e.g. no issues with installation) and platform-interoperability. Also, you could take this opportunity to opt for modularity and go for the DRY principle (e.g. writing a sane API for games using vocabulary testing like the Hangman game). Just my two cents, great job so far! :)

ymohamedahmed commented 8 years ago

We really appreciate your opinion Saleem! We did consider a web-based platform a while back, but ultimately we decided to continue with a desktop application as that's where most of out skills lie. Bearing in mind we did start this over a year ago :) I, for one, would be open to moving to a web-based platform so your advice is appreciated, but we collectively have very little experience in developing web apps.

ghost commented 8 years ago

No problem! Was just a suggestion because I think VTP5 as a platform could benefit greatly by moving to a future-proofed platform. I'm planning of writing something like this in the future, web-based (for simple usage) but with nwjs for desktop platforms, platform-specific glue for mobile platforms. Planning to call it VTP 6 :) but link back to this, unless you don't want me to call it that. Not wanting to intrude or anything :)

The advantage of this is that even though there is a little platform specific code, any "VTP" changes affect all platforms. I run VTP on Linux at the minute but have had to write a separate app for Android.

ghost commented 8 years ago

Sorry for spamming :) Just wondering, could I get access to a copy of the source code? Thanks!

spagy commented 8 years ago

No probs, I'll give you access.

spagy commented 8 years ago

Please don't be too ofended by the source. It's a tribute to the FSM.