search

vtraag / leidenalg

Implementation of the Leiden algorithm for various quality functions to be used with igraph in Python.
GNU General Public License v3.0
596 stars 78 forks source link

Update setup.py to match python-igraph version #38

Closed ragibson closed 4 years ago

ragibson commented 4 years ago

This resolves https://github.com/igraph/python-igraph/issues/299 in this repository. See https://github.com/vtraag/leidenalg/issues/35#issuecomment-638053053.

Note that this issue is also present in https://github.com/vtraag/louvain-igraph, though I know that package is no longer maintained.

ragibson commented 4 years ago

For what it's worth, it seems your CI gets around this by running

git submodule update --init --recursive
python setup.py build_c_core
python setup.py install

but regardless, a bare run of setup.py install without building the igraph C core fails with an UnboundLocalError.

vtraag commented 4 years ago

Thanks for doing this @ragibson ! I will still update louvain-igraph at some later point.