search

vtst / ow

Various Eclipse plugins for web development
http://www.normalesup.org/~simonet/soft/
74 stars 29 forks source link

Working on #72 #139

Closed bytesandwich closed 10 years ago

bytesandwich commented 11 years ago

can find Vars whose type should be implicity required by an @param, but don't get the @param {TYPE} type

using GetImplicitDependenciesNodeTraversal, which is meant to parallel GetDependenciesNodeTraversal

copied NodeUtil and ReferenceCollectingCallback from com.google.javascript.jscomp to net.vtst.ow.closure.compiler.deps, to gather references.

added junit to buildpath: test doesn't pass

bytesandwich commented 11 years ago

It works at least for the simple files I was debugging against.

bytesandwich commented 11 years ago

It also seems to be working when I install it against my proper repo. I just had to delete all the existing warnings and clean and build.

bytesandwich commented 11 years ago

I think partial builds don't work.

bytesandwich commented 11 years ago

The error comes back at weird times.

I think the only way to keep working on this is to add more tests, e.g. #140, which requires plugin development environment tests, or at least knowledge that I haven't gained yet. I'll look into it the next chance I get.

bytesandwich commented 11 years ago

hmm what if I call a method on some object and the return type is a type I never explicitly requried?

bytesandwich commented 11 years ago

Hay @vtst can you take a loot at WorkspaceDriver.addSourceFolder? I'm trying to get testBuild to work in ClosureBuilderTest, and basing WorkspaceDriver off of org.eclipse.jdt.core.tests.builder.TestingEnvironment, but I can't get the project set up correctly.

bytesandwich commented 11 years ago

So, the junit plugin test - closurebuildertest - starts by opening the workspace and creating a project, and trying to put files in the project. I can't seem to get this test project's folders set up correctly.

bytesandwich commented 11 years ago

I think I need some special root folder or something, but I'm not sure. In java I suppose this would be the package root.