vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

Major bug: Magnetic Coordinate Plotting #101

Closed w2naf closed 4 years ago

w2naf commented 10 years ago

Hi, guys.

I started making a new notebook to demonstrate basic SuperDARN data plotting (branch: feature_plotting_notebook), especially in response to request from Judy Stephenson. I especially ran into trouble when trying to plot fan plots in magnetic coordinates:

pydarn.plotting.fan.plotFan(datetime.datetime(2013,3,16,16,30),['fhe','fhw'],param='power',gsct=False)

index

pydarn.plotting.fan.plotFan(datetime.datetime(2013,3,16,16,30),['fhe','fhw'],param='power',gsct=False,coords='mag')

index2

Is anyone else familiar with this problem?

Thanks, Nathaniel

asreimer commented 10 years ago

Which branch are you trying this on? The more information the better.

asreimer commented 10 years ago

By which branch I meant, which did you derive your feature branch from?

w2naf commented 10 years ago

Hi, @asreimer.

It was derived from develop branch, and should be up to date with that branch as of last night.

The only real difference between develop and feature_plot_notebook (aside from the creation of a new notebook) is I added a fig.clf() after a temporary map object creation in order to prevent a second, empty figure from being plotted (https://github.com/vtsuperdarn/davitpy/compare/develop...feature_plot_notebook#diff-1)

If you run the newly created notebook, you should be able to recreate the results I posted.

Take care, Nathaniel

On Sep 18, 2014, at 2:10 AM, asreimer notifications@github.com wrote:

By which branch I meant, which did you derive your feature branch from?

— Reply to this email directly or view it on GitHub.

asreimer commented 10 years ago

Oh of course, I could have tested this on the develop branch to find out... Thanks @w2naf, I was a bit slow earlier.

Yup, confirmed this as a bug. It looks like the coastlines are being drawn just fine in magnetic coordinates up until a certain point. Looks to me like it might be an issue with the detection of the map limits (width and height) (see the to code here: https://github.com/vtsuperdarn/davitpy/blob/develop/pydarn/plotting/fan.py#L172 down to line 233 or so).

The really weird thing is that this works just fine: pydarn.plotting.fan.plotFan(datetime(2013,3,16,16,30),['wal','fhw'],param='power',gsct=False,coords='mag') figure_2

but this doesn't work: pydarn.plotting.fan.plotFan(datetime(2013,3,16,16,30),['cve','cvw'],param='power',gsct=False,coords='mag') and this doesn't work: pydarn.plotting.fan.plotFan(datetime(2014,1,16,16,30),['ade','adw'],param='power',gsct=False,coords='mag')

suggesting that this problem is only affecting radars that share a common site location.

w2naf commented 10 years ago

Ok, thanks for looking at this @asreimer.

I'll try and look at it a little more closely, soon. I'm trying to get a basic plotting example notebook up and running. I also want to add keywords for specifying your own axis object, as well as provide a capability to specify a local fitacf/fitex file.

I think @jspaleta had mentioned something about redoing the plotting routines in general. Am I remembering that right? What was your thinking there?

Thanks, Nathaniel

jspaleta commented 10 years ago

sorry guys I'm out of town for a week or so more. I doubt I'll have a chance to look at this until I get back

asreimer commented 8 years ago

This bug still exists.

ksterne commented 4 years ago

Closing this down as seems as though we never got around to fixing things and this repo has now lost support.