search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

Bugfix sd data types rc params #242

Closed ksterne closed 8 years ago

ksterne commented 8 years ago

As @aburrell noticed in #214, the tmpdir wasn't being set by the rcParams value. This has been corrected as well as added documentation to the sdDataPtr class. Also noted which variables have been set at non-optional based on how the code is setup and/or assert error messages.

I don't have a test for this, although I guess you could set the DAVIT_TMPDIR in your davitpyrc file to something other than /tmp/sd/ . Then run this code in the develop branch and see that using this file doesn't use the directory set in davitpyrc.

To see that this branch doesn't break anything, at least you could do:

from davitpy import *
import datetime

sillyObj = pydarn.sdio.sdDataOpen(datetime.datetime(2015,11,11), hemi='north', fileType='grdex')

And then see that the grdex files are in the tmpdir of your choosing.

asreimer commented 8 years ago

Confirmed that this fixes the issue. Again, not a lot of code was changed so I'm just going to merge this.