search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

Replacing tmpDir with tmpdir #243

Closed ksterne closed 8 years ago

ksterne commented 8 years ago

As noted in #240, found mixedCase variable was replacing the lowercase variable being passed in. Suspect this is ultra-low issue so pulling into develop for the next release. However, if you use:

from davitpy import *
import datetime

time   = datetime.datetime(2014,11,15)

datar = pydarn.sdio.radDataOpen(time, 'bks', tmpdir='PUT YOUR HOME DIRECTORY HERE')

on the develop branch, you'll see it actually ends in an error because the way the if statement is written. The error I found is:

Traceback (most recent call last): File "test.py", line 12, in datar = pydarn.sdio.radDataOpen(time, 'bks', tmpdir='/home/sd-spare1/') File "/usr/local/lib/python2.7/dist-packages/davitpy-0.6-py2.7-linux-x86_64.egg/davitpy/pydarn/sdio/radDataRead.py", line 169, in radDataOpen tmpdir=tmpdir) File "/usr/local/lib/python2.7/dist-packages/davitpy-0.6-py2.7-linux-x86_64.egg/davitpy/pydarn/sdio/radDataTypes.py", line 187, in init d = os.path.dirname(tmpDir) UnboundLocalError: local variable 'tmpDir' referenced before assignment

Using this branch should fix that and you'll have a day's worth of fitex files in your home directory, or wherever you set tmpdir.

asreimer commented 8 years ago

I am confirming that this pull request fixes the bug @ksterne discussed.

What's interesting is that this is only an issue for radDataTypes, but not for sdDataTypes. Probably my fault eons ago.

Since it's such a minor edit, I'm merging this.