Bugfix music and geomagind

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project

http://vtsuperdarn.github.com/davitpy/

GNU General Public License v3.0

37 stars 59 forks source link

Bugfix music and geomagind #265

Closed w2naf closed 8 years ago

w2naf commented 8 years ago

This pull request fixes bugs:

Variables were not passed as strings to the logger in the geomagnetic indices modules, causing them to break.
musicRTI was not updated to the new DavitPy RTI API, causing MUSIC notebooks to break.
datetimeToEpoch did not recognize np.ndarrays as interables

This pull request will make the MUSIC and MUSIC-simulate notebooks work properly again.

MuhammadVT commented 8 years ago

Hi @w2naf,

Running MUSIC.ipynb breaks when the following commands are executed: _# We can use the image processing library in scikit-image to automatically find the peaks representing signals. pydarn.proc.music.detectSignals(dataObj) pydarn.plotting.musicPlot.plotKarr(dataObj)

ImportError: cannot import name findcontours

Also, some of the changes you made in geomag indices related files have been fixed in #256

ksterne commented 8 years ago

@MuhammadVT, have you run ./debian_dependenicies.sh lately? I originally got an error at the same point, although a different error than you. However, I went back and re-ran the dependencies script and I'm getting passed that point. I do get a bunch of VisibleDeprciationWarning's though that look like:

/usr/local/lib/python2.7/dist-packages/davitpy-0.6-py2.7-linux-x86_64.egg/davitpy/pydarn/proc/music/music.py:2124: VisibleDeprecationWarning: using a non-integer number instead of an integer will result in an error in the future

I also get some of these for the last cell's code pydarn.plotting.plotKarrDetected(dataObj)

Otherwise, this notebook does completely run for me.

MuhammadVT commented 8 years ago

as @ksterne has pointed out, it happened to be a local problem with older version of skimage. deleting it from dist-packages and pip install scikit-image fixes the problem. Running MUSIC, MUSIC-simulate and plotGMagIndices.ipynb notebooks all worked fine. Merging it....