search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

report a typo in gmeplot.py #270

Closed Shirling-VT closed 8 years ago

Shirling-VT commented 8 years ago

In the gmeplot.py file from the develop branch, I found a typo in line 246, which is shown below, but should be replaced with if(parameter[0] == 'bye'): ylabel = 'By GSE [nT]'. It's not something serious, you will result in a ylabel of "BYE" instead of "By GSE [nT]". Anyone wants to correct it?

246 if(parameter[0] == 'bze'): ylabel = 'By GSE [nT]' 247 if(parameter[0] == 'bze'): ylabel = 'Bz GSE [nT]'

asreimer commented 8 years ago

Hi @Shirling-VT,

I've made a pull request (#271) to fix this issue. Can you please provide some code to test it (perhaps the code you used to find it)?

Shirling-VT commented 8 years ago

BTW, I just found this typo accidentally when I was reading through the code. The testing code is provided in another email I just sent.

On Tue, Aug 30, 2016 at 2:10 PM, Ashton Reimer notifications@github.com wrote:

Hi @Shirling-VT https://github.com/Shirling-VT,

I've made a pull request (#271 https://github.com/vtsuperdarn/davitpy/pull/271) to fix this issue. Can you please provide some code to test it (perhaps the code you used to find it)?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vtsuperdarn/davitpy/issues/270#issuecomment-243528786, or mute the thread https://github.com/notifications/unsubscribe-auth/AIEZK6szanpFjxx_bU64FdTrg5bo0UYJks5qlHIIgaJpZM4Jwqia .

Best wishes, Xueling

asreimer commented 8 years ago

It was a good find!

Resolved by #271.