search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

Virtual height models #273

Closed aburrell closed 7 years ago

aburrell commented 8 years ago

Currently, only the Standard model is available. The Chisham model has been shown to be more accurate and should be provided.

aburrell commented 8 years ago

I'm getting ready to add this functionality and trying to figure out the best place to put the additional routines. Any thoughts on these options on where to place the routines for the standard and chisham virtual heights?

A) utils

B) a virtual_height directory in models

C) a virtual_height directory in proc

@asreimer, @Shirling-VT, @ksterne, @MuhammadVT ?

asreimer commented 8 years ago

Hey @aburrell

Where is the current model implemented in davitpy? I'm assuming that these virtual height models are used for generating radar FOV, but I'm not entirely sure.

I would prefer to keep code that does similar things grouped together, so if the virtual height models should all go in the same place as the FOV generation code.

Cheers, Ashton

aburrell commented 8 years ago

The model is not placed seperatly, rather incorporated into whichever routine needs to use it. Now that there are multiple models available, it made sense to me to give them their own place. It is currently being used by radFov (pydarn/rad) and update_backscatter (pydarn/proc/fov). This became tricky because one could view this as being a model that provides more location information, and therefore similar to ray tracing. Or a part of the FOV, and put it in radar, or a part of geolocation, and put it in utils.

I’m assuming you vote for putting it in pydarn/radar?

On 12 Oct 2016, at 02:57, Ashton Reimer notifications@github.com wrote:

Hey @aburrell https://github.com/aburrell Where is the current model implemented in davitpy? I'm assuming that these virtual height models are used for generating radar FOV, but I'm not entirely sure.

I would prefer to keep code that does similar things grouped together, so if the virtual height models should all go in the same place as the FOV generation code.

Cheers, Ashton

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vtsuperdarn/davitpy/issues/273#issuecomment-253097940, or mute the thread https://github.com/notifications/unsubscribe-auth/AGuC_m5DfFFwvUvIKKKQFDVMqCDRKVHfks5qzD6BgaJpZM4KSl7S.

aburrell commented 8 years ago

Being addressed in #274

aburrell commented 7 years ago

This issue was addressed in #274