search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

Removed problematic and unused rcParam #325

Closed aburrell closed 7 years ago

aburrell commented 7 years ago

Removed the rcParam ‘DAVITPY_PATH’, which has caused installation issues and is not used anywhere at all (that I could find).

This pull request was made in response to issue #309 .

asreimer commented 7 years ago

Let me take a look before this gets merged. I originally coded up the rcParam stuff so I can test it. I'll try to look this weekend.

aburrell commented 7 years ago

Thanks Ashton!

On 12 Oct 2017, at 18:56, Ashton Reimer notifications@github.com wrote:

Let me take a look before this gets merged. I originally coded up the rcParam stuff so I can test it. I'll try to look this weekend.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/vtsuperdarn/davitpy/pull/325#issuecomment-336312832, or mute the thread https://github.com/notifications/unsubscribe-auth/AGuC_taoZpdImFEowZT0g_QSnSy612IQks5srqcngaJpZM4P0kBq.

asreimer commented 7 years ago

I'm investigating, but I don't think we can simply remove this rcParam.

As a naive check, running grep -lr "DAVITPY_PATH" * I see that DAVITPY_PATH is actually used in a few places, specifically:

davitpy/rcsetup.py
davitpy/models/iri/__init__.py
davitpy/models/hwm/__init__.py
davitpy/models/hwm/hwm_input.py
davitpy/models/raydarn/rt.py

This is because this path is set so that those models can find the coefficient files that they need to run.

The approach here seems like, DAVITPY_PATH is causing problems so let's just delete it, but we don't know why it's causing the problems. I would much rather see us get to the bottom of the problem so it can be properly addressed.

I'm going to do more investigating, but I'm also closing this pull request.