search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

bad asserts in fetchUtils #330

Closed asreimer closed 6 years ago

asreimer commented 6 years ago

The outdir asserts found here and here are bad.

Specifically the outdir[-1] == "/" part is nasty.

Using os.path.join automatically handles all of the slash problems with joining paths together. So we should remove this from the asserts.

Additionally, line 652 needs to be changed to:

tf = os.path.join(outdir, rf)
ksterne commented 6 years ago

Hey @asreimer, is this hotfix worthy? Or just needs to be updated for next release?

ksterne commented 6 years ago

Time to close this @asreimer?

asreimer commented 6 years ago

Fixed in #336