Closed asreimer closed 6 years ago
The outdir asserts found here and here are bad.
outdir
Specifically the outdir[-1] == "/" part is nasty.
outdir[-1] == "/"
Using os.path.join automatically handles all of the slash problems with joining paths together. So we should remove this from the asserts.
os.path.join
Additionally, line 652 needs to be changed to:
tf = os.path.join(outdir, rf)
Hey @asreimer, is this hotfix worthy? Or just needs to be updated for next release?
Time to close this @asreimer?
Fixed in #336
The
outdir
asserts found here and here are bad.Specifically the
outdir[-1] == "/"
part is nasty.Using
os.path.join
automatically handles all of the slash problems with joining paths together. So we should remove this from the asserts.Additionally, line 652 needs to be changed to: