search

vtsuperdarn / davitpy

DEPRECATED The DaViT Python project
http://vtsuperdarn.github.com/davitpy/
GNU General Public License v3.0
37 stars 59 forks source link

Concern with gsMapSlantRange function #353

Closed egthomas closed 4 years ago

egthomas commented 6 years ago

I have a concern with the function gsMapSlantRange added in commit 6feea98 to radFov.py. I'm not sure that Bristow et al. [1994]'s range calculation is applicable here. The equation in that paper is solving for the ground range to the ionospheric reflection point (D) and not the slant range to the reflection point (R/2).

I'm also not convinced the equation in that paper is even correct for solving the ground range to the ionospheric reflection point of a ground scatter echo, but that's another matter.

egthomas commented 6 years ago

I don't suppose this issue came up during the developer telecon?

Shirling-VT commented 6 years ago

Hi Evan,

You are right. We discussed all the pull requests and didn't have enough time to go through all the issues during the developer telecon.

ksterne commented 4 years ago

Apologies @egthomas that this was never addressed or fixed. One of davitpy's many flaws. Closing this issue now at the repo is being deprecated.