search

vtt-lair / foundry-group-initiative

Module for Foundry VTT that allows you to roll grouped initiative.
MIT License
3 stars 4 forks source link

No longer works for Pathfinder 2e ruleset #13

Open roguedevjake opened 2 years ago

roguedevjake commented 2 years ago

Tested on fresh world with no other modules or settings set. Foundry Version: 0.8.9

  1. Clicking roll group or roll group npcs buttons roll one npc at a time
  2. While group rolling sometimes npcs are grouped together, sometimes they are split into multiple groups
  3. The group's initiative is set by the highest individual roll in the group
vtt-lair commented 2 years ago

Hey @roguedevjake, thanks for letting me know. I'm releasing a new version later this week. Would it be possible for you to check against that version as well. I fixed a few bugs and hopefully it'll sort yours out too.

I'll comment here when the new version is released.

bbollig commented 2 years ago

Experienced the same issue last night while testing out the mod to see if I could make use of it for my game since I had a big combat coming with multiple groups competing against each other. In one case, I had a PC grouped under a Monster's initiative; in another, it was mixing two different groups of Monster NPCs at multiple initiatives; also, some Monsters who could have been nested in other places had stand-alone turns in the tracker.

There were other issues as well but it was hardly a clean test, since I have other mods installed that have the initiative tracker in common. But I wanted to chime in anyway because I could put this module to great use. Looking forward to the next release to try it again.

AnnoUltima commented 2 years ago

Hi, just commenting that I am also experiencing this problem as of December 23rd.

vtt-lair commented 2 years ago

I'll have to investigate the PF2E system, as it's initiative rolls (and honestly all it's rolls) works differently than the DnD 5e or most other systems.

I had to do a huge refactor on the Let Me Roll That For You module specifically because PF2E calls rolls differently. Will try and get to this refactor in the next week or 2. Sorry for the delay.

Ghilteras commented 1 year ago

@vtt-lair this seems still broken for pf2e system, any chance we can fix this?

vtt-lair commented 1 year ago

I've just had a look at this. And what seems to happen with PF2e vs other systems, when the initiative is rolled, the combact tracker isn't updated immediately. This is possibly due to the modal for PF2e's initiative showing and only rolling on that button press.

However, I would have expected that since I'm waiting for results (i.e. I'm waiting for the initiative rolls) that the combat tracker would be updated. In other systems, the combat tracker is updated and reflects as soon as the roll is cast, for PF2e it seems to only register the roll at a later stage.

As such when I try and update the rest of the combatants that has been grouped together, it just updates it to an empty initiative, since the rolled combatant's initiative hasn't actually been updated yet.

No idea what to do here unfortunately.

Ghilteras commented 1 year ago

Have you tried asking the pf2e system devs on discord? I'm pretty sure they can help you figure out how to make this working again. They are super helpful