search

vtt-lair / foundry-group-initiative

Module for Foundry VTT that allows you to roll grouped initiative.
MIT License
3 stars 4 forks source link

Modification of Core HTML Tag - "Details" breaks core FoundryVTT Functions #25

Closed Aeristoka closed 2 years ago

Aeristoka commented 2 years ago

https://github.com/vtt-lair/foundry-group-initiative/blob/master/templates/group-collapse.html

The CSS in that template which modifies the Details core HTML Tag breaks the placement of arrows in many places that they are used in FoundryVTT.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

In example, a chat message posted with a Details element working properly:

image

And the exact same Chat Message with this module enabled:

image

kakaroto commented 2 years ago

Note: The message using the details tag posted above is from Beyond20. customizing CSS of core html tags is problematic because of conflicts like these. Your own html should be using a class and your CSS should be specific to that class, for example : <details class="group-initiative"> and using details.group-initiative for your custom CSS

vtt-lair commented 2 years ago

Thanks for pointing this out. That is a rather stupid mistake. Will work on it during this week.

Aeristoka commented 2 years ago

Thanks for pointing this out. That is a rather stupid mistake. Will work on it during this week.

I'm nothing if not able to stumble upon weird crap 😄

vtt-lair commented 2 years ago

I've created a new task to refactor the headers: #29