search

vtt-lair / simbuls-cover-calculator

A Foundry VTT module that calculates cover for DnD 5e
MIT License
6 stars 4 forks source link

1.4.0 problems with Midi-QOL #42

Closed rafacrudi closed 1 year ago

rafacrudi commented 1 year ago

Hi! After updating to 1.4.0, Midi-QOL stopped auto applying damage to tokens.

When I went back to 1.3.3, it started working again.

This is what I found on the console: Shape.js:77 Uncaught (in promise) ReferenceError: undefined. MODULE is not defined [Detected 2 packages: simbuls-cover-calculator, midi-qol] at Shape.buildWall (Shape.js:77:44) at CoverCalculator.js:524:76 at Array.map () at Cover.buildWallData (CoverCalculator.js:524:58) at Cover.calculate (CoverCalculator.js:492:14) at new Cover (CoverCalculator.js:482:14) at Object._Cover [as Cover] (CoverCalculator.js:449:16) at computeCoverBonus (utils.js:1996:50) at Workflow.checkHits (workflow.js:2792:16) at Workflow._next (workflow.js:449:17) at async Workflow.next (workflow.js:247:10) at async Item5e.doAttackRoll (itemhandling.js:497:2) at async Workflow._next (workflow.js:414:6) at async Workflow.next (workflow.js:247:10) at async Workflow.next (workflow.js:247:10) at async Workflow.next (workflow.js:247:10) at async Workflow.next (workflow.js:247:10) at async Workflow.next (workflow.js:247:10) buildWall @ Shape.js:77 (anonymous) @ CoverCalculator.js:524 buildWallData @ CoverCalculator.js:524 calculate @ CoverCalculator.js:492 Cover @ CoverCalculator.js:482 _Cover @ CoverCalculator.js:449 computeCoverBonus @ utils.js:1996 checkHits @ workflow.js:2792 _next @ workflow.js:449 await in _next (async) doItemUse @ itemhandling.js:327 await in doItemUse (async) 🎁call_wrapper @ libWrapper-wrapper.js:616 🎁CONFIG.Item.documentClass.prototype.use#0 @ libWrapper-wrapper.js:189 _onItemUse @ base-sheet.mjs:1170 (anonymous) @ tidy5e-favorites.js:555 dispatch @ jquery.min.js:2 y.handle @ jquery.min.js:2

Hope it helps! :)

vtt-lair commented 1 year ago

Thanks, will have a check as soon as possible

Nedrapter commented 1 year ago

I'm noticing issues too. While Sinbul's Cover Calculator is active, the damage rolls from an attack do not come through by Mid-Qol. It doesn't even display a damage button on the attacks.

vtt-lair commented 1 year ago

Just wanted to double check @Nedrapter & @rafacrudi. Is this happening on v10?

vtt-lair commented 1 year ago

@rafacrudi it seems like the error shown is when it's trying to log an error. I'll fix that and hopefully we can get the actual error logged.

I might also need both your and @Nedrapter's midi-Qol settings, as I'm not experiencing the same issue and it could be related to settings that I don't play with myself. Or even a specific scenario related to attacking through walls with heights

rafacrudi commented 1 year ago

Just wanted to double check @Nedrapter & @rafacrudi. Is this happening on v10?

@vtt-lair Yes, it's on v10. I didn't test on v11 yet.

Nedrapter commented 1 year ago

I'm on v10 as well, but I can't reproduce the issue anymore. I re-enabled sinbul's CC and now seems to be working. Between the problem and now I think I did update Mid-QoL one version up.

vtt-lair commented 1 year ago

Cool, that's good news @Nedrapter. I'm going to release a version just now that should fix the error that you shared @rafacrudi and also flag the module as v11 verified.

If you run into the issue again with the next version update, we should at least have proper logging now