Player's token don't provide cover

[Bradeck]

For me : NPCs token provides cover, PCs token don't. I maybe have missed a setting somewhere, but for me on the latest version (and maybe even before that, I have gone now gone down to 1.45 to revert this issue).

Here's a little video to demonstrate. A player token is configured by default to provide +1 cover, but does not. The NPC token just works fine. cover_calculator.webm

I can't determine why. As per the video I have tested with only your mod, his dependency, and the Forge, active.

Thanks :-)

[NdranC]

I have this exact issue. Only NPC tokens provide cover.

[vtt-lair]

Will spend some time during the next week to see what I going on here

[matt-duffy]

Don't suppose you have had a chance to look at this yet?

The exact scenario I have found is that if I have these settings on a player token:

Provides Cover: Half cover (+2) Provides Cover (Dead): No cover Provides Cover (Prone): No cover

Then the player token never provides cover, even when it is not prone or dead/unconscious.

But these settings will work fine on a player token:

Provides Cover: Half cover (+2) Provides Cover (Dead): Half cover (+2) Provides Cover (Prone): Half cover (+2)

However, for an NPC token these settings work as expected:

Provides Cover: Half cover (+2) Provides Cover (Dead): No cover Provides Cover (Prone): No cover

[vtt-lair]

Hey, unfortunately have had a bit of a family emergency over the last month and haven't been able to spend time on this. I should hopefully get some free time in the next few weeks.

[matt-duffy]

It's a great module, thanks for all the hard work on it but family always comes first!

[vtt-lair]

@matt-duffy, @Bradeck, @NdranC

Sorry I've been so slow in looking at this.

I've just run the same test that both @Bradeck and @matt-duffy supplied and I'm not able to duplicate the issue. In both scenarios, the "friendly" token blocked cover as expected.

One thing that I must remind you, if you make changes in the main settings to the token sizes. It doesn't update any tokens already on the scene, those you need to manually update in the token's settings OR remove from the scene and re-add.

That being said, could you possibly supply me with screenshots of the each settings page you are using. Maybe there is some setting that I don't have set that is causing this issue

[matt-duffy]

HI @vtt-lair just to be clear, the problem is not that player tokens don't ever provide cover.

The problem is that the player token only provides cover if you have all 3 options selected for a player token.

Here is the scene:

And here is the setup on the player token in the middle:

Then when I roll:

No cover.

But if I set all 3 options to half cover:

And then roll:

Cover is working as expected

[matt-duffy]

Contrast that with a hostile token with the same settings:

And there cover works as expected:

So the problem is that a friendly token set to only provide half cover when not dead/prone does not provide cover in at all

Core Version: 11.315

System: dnd5e 3.1.2 (Atropos) 

Modules: 
simbuls-athenaeum 1.0.7 (VTT Lair)
simbuls-cover-calculator 2.0.4 (VTT Lair)

[vtt-lair]

Thanks, @matt-duffy.

Interesting. Will you send me a screenshot of you Cover Calculator System setting page, as well as your Cover Settings (that whole subsection) in the Misc tab of Midi-QOL?

[matt-duffy]

Midi QOL

[vtt-lair]

That is so weird. I just updated my settings to make 100% sure we have the same and on my side it's working as expected. I'll play around some more to double check if I can find something

[pumpkin1972]

@matt-duffy I am having the same/similar issue. I think specifically the calculator is treating the PC token as dead, regardless of whether it is or not. If you switch the 3 settings to be different (i.e. dead, prone, cover all set uniquely for the size of token) is the PC token always taking the "dead" setting?

[vtt-lair]

@matt-duffy @pumpkin1972 would it be possible to maybe get access too your system. Even if it's just as a player, I just want to debug and see if I can see what is different between yours and mine. You're more than welcome to search for me on the Foundry Discord and message me there directly instead of sharing that kind of details here publicly

[pumpkin1972]

sure, do you want access to the full world where it seems like it is treating PCs as dead or the one where the sizes are showing as [object object] .... interestingly that might be calculating cover correctly but difficult to tell because cant tell which size is which. I'll find you on foundry

[vtt-lair]

@pumpkin1972 both would be perfect, as I can't get the [Object object] issue replicated either

[pumpkin1972]

no problem, sent you a message on discord->foundry

[matt-duffy]

Hey @vtt-lair do you still need access to an environment to see the PCs not providing cover or have you got that from pumpkin1972 as well?

[vtt-lair]

Hey @matt-duffy I've had a look at pumpkin's one server for the visual issue in settings, but have not had a chance yet to look at the big problem on his server. I'm only really available again to debug from tomorrow and over the weekend.

That being said, if you would like to give me access to your server too over the weekend to debug this issue. Then that would be great. You can send me the details in Discord. User under Foundry's Discord should also show up as VTT-Lair

[Bradeck]

EDITED, TWICE ! Sorry to chim in so late, I had to test it properly to be sure.

I had the problem that PC token don't provide cover, but now it's fixed. I thought it was an update that fixed it, but as some still have the problem, it seems more complicated than that.

• Foundry v11.315
• DD5e 3.1.2,
• hosted on the forge
• Simbul's Athenaeum 1.0.7
• Simbul's Cover Calculator 2.0.5
• They are the only module active, with the mandatory Forge One

[pumpkin1972]

EDITED, TWICE ! Sorry to chim in so late, I had to test it properly to be sure.

I had the problem that PC token don't provide cover, but now it's fixed. I thought it was an update that fixed it, but as some still have the problem, it seems more complicated than that.

• Foundry v11.315
• DD5e 3.1.2,
• hosted on the forge
• Simbul's Athenaeum 1.0.7
• Simbul's Cover Calculator 2.0.5
• They are the only module active, with the mandatory Forge One

That’s interesting it’s fixed. I still have it on main world but with a fresh world with same modules it is mostly working… In the fresh world I do get issues if the “blocking” token has a cover effect on it, then it doesn’t count as cover (I.e if that token is between attacker and target SCC doesn’t register it for cover) so I wonder if there are a few unique scenarios where there is a conflict and we aren’t realising they are existing in our test set up… Is it working with exact same PC tokens, same situation etc?

[pumpkin1972]

@Bradeck one thing - now it's fixed, what are you "dead" PC tokens set as? No cover, or something else...

[Bradeck]

Here are my setting : Cover levels :

Token Cover Size Settings

Setting for PC token used for the test, he's an eladrin, so medium creature :

[Bradeck]

Is it working with exact same PC tokens, same situation etc?

Yep, I use the same scenario as the one in the video posted in my first post. I can't say for sure it's exactly the same, as the PC have gained levels though. But it's the same PC, the same monster, all in a line, on the same map.

[pumpkin1972]

did a bit more testing and when it doesn't work correctly.. it is because the system is treating the PC token as dead even when it has HP and does not have the dead status - this may be why it is fixed for you, because it is no longer seeing the PC token as dead. @vtt-lair how does the module determine if a token is dead? can always take a look at my world this weekend if that is helpful

[vtt-lair]

@pumpkin1972 for dead it checks if the actor's hp is either <= 0 or whether it has the unconscious effect on it

If either the HP is 0 or below, or it has an unconscious effect then it flags the cover level as the dead cover level.

Also remember if you make changes in the Settings itself (not on the token), that a new token needs to be added to the map (it only refreshes those values on token create)

[pumpkin1972]

Yer I changed it specifically at the token level, let me have a play with those other settings - no unconscious effect set or anything like that,