vtt-lair / simbuls-creature-aide

A Foundry VTT module that aids in combat. legendary actions, lair actions, recharge abilities and regeneration.
MIT License
2 stars 2 forks source link

[Bug] Undead Fortitude Damage Clamping #4

Closed harrisog closed 1 year ago

harrisog commented 1 year ago

Undead Fortitude save DCs are currently being calculated using only the damage done to reduce the target to 0 hp, i.e. a zombie with 1 hp is always rolling a DC 6 save (with a +3 bonus lol)

vtt-lair commented 1 year ago

@harrisog is this for the Advanced calulcation? The one that prompts you for the damage and auto fills it?

If so, I'll have a look. I know the original didn't have the auto-fill and this could be why. Will have a look tonight.

harrisog commented 1 year ago

Both "quick" and "advanced" methods as far as I can tell. Tested this with minimal mods loaded in before reporting, although one of them was midi-qol

vtt-lair commented 1 year ago

Without midi:

Quick Saves Zombie has 12 health, takes 13 damage image

DC is 5 + 13 image

Zombie has 12 health, takes 25 damage image

DC is 5 + 25: image


Advanced Saves Zombie has 12 health, takes 13 damage Damage to target is auto populated with 13, but you can put anything there: image

DC is thus 5 + 13 image

Zombie has 12 health, takes 13 damage, damage is autopopulated: image

But it's overwritten to 27: image

DC is thus 5 + 27 image

Will make a separate post for with midi, to see what happens (don't have midi installed on my development version, so give me a few minutes to set everything up)

vtt-lair commented 1 year ago

Seems like it's related to midi. As midi only does enough damage to take it to 0 and not overkill. Looking at the original design of the Undead Fortitude feature in DnD5e Helpers, this is exactly what the "Advanced" options was created for.

The "Quick" one doesn't take overkill into account when using midi. The "Advanced" is there so that you can override midi who doesn't add overkilling damage and enter the value of the actual damage. I just populate it with the damage received from midi, but you can override it.

As such, I'm flagging this as closed as it's acting in the expected way.