Incompatibility, some bugs and some suggestions :-)

[MSAbaddon]

Hi, first things first - this is a great module, I love it.

Due to this fact I want to use the module, but unfortunately ran into several issues:

• The module seems to be incompatible with the Assets Library of The Forge. I can select a folder within the Assets Library as a location for token images, but when I try to import actors an error is thrown

• When I manually create an actor in the actors tab with "replace token and portrait art" enabled, only the portrait art is replaced, the portrait stays at mystery man

• The randomization of tokens seems to not function corectly - out of three available images only two are used

• One feature suggestion: It would be great if token and portrait art could be handled separate from each other, e.g. by using a definable prefix like 'portrait' in the file names. That would allow a DM to put x files for the tokens and one different file for the portrait into the directory and let the module replace both in one step instead of having to manually choose the portrait every time.

[vtt-lair]

Thanks for the feedback @MSAbaddon. I'm currently away on vacation, but I will look at this as soon as I'm back and able.

[MSAbaddon]

That's great news, thanks for the info and have a great vacation :-)

[MSAbaddon]

One more suggestion: When searching for tokens/portraits, include subfolders below the initial cr-folder. Would allow some more structure within folders which contain a lot of tokens (e.g. cr0 containing all the townsfolk, commoners, guards and desert guards tokens from Forgotten Adventures.

[vtt-lair]

@MSAbaddon Just to keep you updated, I've made a few fixes that I'm currently still testing. Should be released by this weekend:

• I've fixed the compatibility issue with The Asset Library of The Forge.
• I've fixed the issue with the portrait not updating on manually created actors. I'm still sitting with an issue where the first time the token is placed, the token isn't being updated. Will see if I can get this sorted out (is a known issue since the module was first released).
• I've changed the randomisation formula that seems to be working a bit better. Also remember that if you add any new images in the folder, you will have to refresh your foundry page to ensure the new image is cached.
• I've added the ability to specify a prefix for portraits in the settings. The prefix that you use must be exact, so if you use "portrait" then the file must be "portraitDeepScion.png", similarly if it's set to "p" the file will have to be "p_Deep_Scion.png". Portraits are only set once, usually on actor creation. I've added logic that if the portrait isn't set and there is a portrait for the actor, it will set it when you create a token but this will only happen once.
• The last suggestion I started implementing, then realised it's a bit more involved. Because I cache the image names, they will be cached with those subfolders as part of the name. So when trying to see if the actor that you are using has an image, the format of my check will not have those subfolders as part of the check and then won't find the file(s). I'll spend some time to see if I can figure out a solution for this. So I doubt this will be implemented by this weekend

[MSAbaddon]

Wow, that's great news, thanks for the update :-)

[vtt-lair]

@MSAbaddon your requested enhancements and bug fixes has been released in v0.2.2

[MSAbaddon]

Awesome :-)

Did you also implement the subfolder suggestion?

One mor thing regarding portrait art: If I opt to replace both portrait and token and set a prefix, the module works fine as long as there actually is a portrait file available. If no portrait file is available though, no replacement happens (neither portrait nor token). Would be great if - in case no portrait is found - the module tries again to find a portrait ignoring the set prefix and instead use one of the available token images.

[vtt-lair]

I wasn't able to implement the subfolders.

Interesting, I did code it in such a way that it's supposed to fall back to the other if it wasn't found. Will see what's potting and create a hotfix for it.

[vtt-lair]

I did a hotfix release v 0.2.3 to fix the issue with the portrait art and fallback not working as expected. Should now be working.

[MSAbaddon]

Nice :-) Just testet it and looks great. One last thing I noticed - it sometimes happens that the first token being replaced looks like this: