search

vtt-lair / token-replacer

Foundry VTT - Automatically replace NPC actor tokens and/or portraits dependent on token assets saved in a defined folder structure
MIT License
5 stars 4 forks source link

Cannot install module #67

Closed rocuonji closed 3 years ago

rocuonji commented 3 years ago

Trying to install through foundry and get this error "installation failed: k is not defined" Tried to use the .json link directly and got a similar one : "installation failed: the request to https://github.com/vtt-lair/token-replacer/blob/main/module.json did not provide a valid manifest file." image

Using foundry version 0.8.7

vtt-lair commented 3 years ago

That is peculiar. There was an issue with the manifest file location it seems, which I've updated and the url now works. I'm however still getting the "k is not defined" error when trying to install it via the installation button. What is weird is that I was able to update to the newer version when I released it this week... just the new install causing issues.

Using the following manifest file works though: https://github.com/vtt-lair/token-replacer/releases/latest/download/module.json

I was able to install it using that... will try and figure out why the other error is happening.

vtt-lair commented 3 years ago

Ok... found the issue. With the previous release I changed the manifest url to go directly to the versioned url instead of the latest url. The problem being that the manifest url in the module.json was still referencing the latest version.

So the url on my release manifest vs what it was in the module.json was different and caused the issue. I've fixed it now and a after refreshing (F5) on Foundry, it will now download using the install button.

Thanks for bringing this to my attention @rocuonji

rocuonji commented 3 years ago

Hey, my pleasure. Thanks for fixing it so quick! Keep up the great work!