vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 56 forks source link

Improves & Translation on the new Shopping cart #190

Open WallaceMcGregor opened 2 years ago

WallaceMcGregor commented 2 years ago

I've made a few tests with the amazing new shopping cart and would be great adding some little changes.

The first one It would be to be able of using translated coins. It only works with GP. Also, If the added starting gold could be translated It will be great.

The second one is to show only the item name and the total cost in the chat card. Descriptions of items can use too much space.

chrome_REi6p0Zixe

anthonyronda commented 2 years ago

It definitely takes up a lot of room with a full kit.

I got some other feedback on the chat card. First let me explain why I made this in response to the request in #26 with a user story.

  1. Player wants to make a new character. Player already has an empty character sheet open. Player has Owner permission for it.
  2. Player clicks the flashing red dice icon in the portrait hover menu.
  3. Player clicks "Auto" in the Character Gen form application, which rolls all dice and outputs the ability scores and gold to the chat. At the same time, it updates the character sheet. Gold is given as "GP" item in the player's inventory. All players can see/reference this character's stats so they can possibly strategize.
  4. Player drags and drops several items into the character sheet.
  5. Player clicks the white "coin stacks" icon in the portrait hover menu.
  6. The Shopping Cart shows all items in the inventory. The player clicks Purchase with xxGP.
  7. The GP in the Player character's inventory (created during character generation) is deducted for the total cost of the character's inventory.
  8. The inventory is posted to chat, which allows all players to see/reference items that the player took so they can possibly strategize.

My question (for everyone): is the information posted to chat used as a reference by other players in this way?

Answering your suggestions

WallaceMcGregor commented 2 years ago

In my opinion, the items description posted to chat is redundant because the players can look the compendium. It looks fine to me the idea of an item summaries drop down when the item is clicked, but this will only saves you a couple of clicks.

In any case I said some ideas after messing around a few minutes with this new feature, and maybe It is too much time consuming for something that is only useful during character creation.

Thanks

anthonyronda commented 2 years ago

In a v2 of this feature, I'd like to make it useful for any new merchant visit. For now it's better to use OSR Item Shop for that

WallaceMcGregor commented 2 years ago

For now it's better to use OSR Item Shop for that

Is that a Foundry module? I didn't found It and I'm interested 😋

anthonyronda commented 2 years ago

@WallaceMcGregor https://github.com/RabidOwlbear/osr-item-shop

anthonyronda commented 2 years ago

The suggestion to use a localized abbreviation for GP has been implemented in #194. We will need to wait for new translations to be available.

I decided to wait on the dropdown item summary until some other time