vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

Dropping an item into a container duplicates the item #209

Closed eegag closed 2 years ago

eegag commented 2 years ago

What happened?

  1. Open character sheet
  2. Navigate to inventory tab
  3. Dragged GP item into container item
  4. GP item duplicated itself in treasure section and did not move to the container

What is the expected behaviour?

  1. Open character sheet
  2. Navigate to inventory tab
  3. Dragged GP item into container item
  4. GP item moves to container section beneath the selected container item and no longer shows in the treasure section

Relevant Errors and Warnings

No response

Additional Support Details

Foundry Virtual Tabletop: Version 10, 10.283 Game System: ose, 1.6.0 Active Modules: 0 Performance Mode: 2

OS: Unknown Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) FoundryVirtualTabletop/10.283.0 Chrome/94.0.4606.81 Electron/15.3.5 Safari/537.36 GPU: ANGLE (NVIDIA, NVIDIA GeForce GTX 760 Direct3D11 vs_5_0 ps_5_0, D3D11-27.21.14.5671) Max Texture Size: 16384

Scene: 3840 x 1920 | Grid Size: 100 | Padding Percentage: 0 Walls: 0 | Ambient Lights: 5 | Ambient Sounds: 0 | Tiles: 1 | Tokens: 0

Actors: 1 | Items: 0 | Journal: 0 | Rollable Tables: 0 | Playlists: 0 | Compendium Packs: 0 | Chat Messages: 1

Foundry VTT Core Version

V10

Old-School Essentials Core Version

1.6

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Chrome

Code of Conduct

anthonyronda commented 2 years ago

There is a change to the dragDrop API in V10 that I believe I missed

anthonyronda commented 2 years ago

Root cause found, appears to be unrelated to the change in the dragDrop API. It's a corner case of the change in the data model

anthonyronda commented 2 years ago

Fixed in #235