search

vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 57 forks source link

Enhancement: Ability to show ability/item card to chat if no rolldata exists #321

Open bakbakbakbakbak opened 1 year ago

bakbakbakbakbak commented 1 year ago

What happened?

  1. I tried clicking the icon for an armor or an ability without roll data

What is the expected behaviour?

When I click the icon, I expect it to show an itemcard in chat displaying the properties of the item.

Relevant Errors and Warnings

No response

Additional Support Details

Foundry Virtual Tabletop: Version 10, 10.291 Game System: ose-dev, AUTOMATICALLY REPLACED BY GITHUB WORKFLOW ACTION Active Modules: 3 Performance Mode: 0

OS: Unknown Client: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) FoundryVirtualTabletop/10.291.0 Chrome/94.0.4606.81 Electron/15.3.5 Safari/537.36 GPU: ANGLE (AMD, AMD Radeon RX 590 Series (polaris10 LLVM 14.0.6), OpenGL 4.6 (Core Profile) Mesa 22.3.1) Max Texture Size: 16384

Scene: 6000 x 4600 | Grid Size: 100 | Padding Percentage: 0.25 Walls: 0 | Ambient Lights: 0 | Ambient Sounds: 0 | Tiles: 0 | Tokens: 3

Actors: 4 | Items: 0 | Journal: 1 | Rollable Tables: 0 | Playlists: 0 | Compendium Packs: 35 | Chat Messages: 1

Foundry VTT Core Version

V10

Old-School Essentials Core Version

No response

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

No response

Code of Conduct

anthonyronda commented 1 year ago

I'm unsure, is this for the inventory tab of the actor sheet or the item sheet itself?

bakbakbakbakbak commented 1 year ago

I'm unsure, is this for the inventory tab of the actor sheet or the item sheet itself?

This is from the inventory tab of the actor sheet. I just realized that abilities are shown to chat using the eye icon, but I can find no such thing for armor for example.

anthonyronda commented 1 year ago

It's very likely relevant in a lot of cases, but I don't know what the best designed solution is for the inventory sheet.

This is really an enhancement, right? It's following the designed behavior and we just need to decide on a design that allows people to show each other what certain items do, such as when there's a rule question?

bakbakbakbakbak commented 1 year ago

I agree, I'll change the title to reflect it being a suggested enhancement!