fix(dice): Dice rolling fixes for 1.8.x - Githubissues

vttred / ose

Old-School Essentials – Foundry VTT Edition

https://ose.vtt.red

GNU General Public License v3.0

96 stars 57 forks source link

fix(dice): Dice rolling fixes for 1.8.x #345

Closed bakbakbakbakbak closed 1 year ago

bakbakbakbakbak commented 1 year ago

resolves #341, resolves #340, resolves #333

Reworked tests for dice
- Moved createMockData and createMockAttackData into tests as they were only used there
- Updated createMockRoll to properly mock a roll as needed by tests
- Rewrote the tests for attackIsSuccess to better explain functionality
- Rewrote digestAttackResult tests
- Updated createMockRoll calls
- 340 : Added tests for these cases
- Reformulated createMockRoll calls to calculate values instead of using hard-coded values.
  - Calculations include calculating attack bonus from thac0 score.
- Rewrote sendAttackRoll tests
- Removed majority of tests that were just checking the chat messages for content
- Updated the mocking data to more accurately represent actual data from weapon rolling
Dice helper
- Fixed digestResult
- Added description
- Didn't use proper value for die
- Reworked attackIsSuccess to make it more understandable.
- Added description
- To use it will take:
  - roll, target, bonus for Ascending AC
  - roll, thac0, ac for Descending AC
- Linted the last if return statement.
- 342: Incorporates the changes in said PR.
- Rewrote digestAttackResult
- Added description
- 333 : Updated default AC and AAC values to always allow to hit target unless target is selected (except for natural 1s).
- 341 : Rewrote logic to support Ascending AC & Descending AC utilizing attackIsSuccess
- Properly flags when an Ascending AC roll fails (previously didn't set result.isFailure)
- Added description for sendAttackRoll

bakbakbakbakbak commented 1 year ago

Marking this as draft until it solves #340 too. Looking into this tomorrow.