search

vttred / ose

Old-School Essentials – Foundry VTT Edition
https://ose.vtt.red
GNU General Public License v3.0
96 stars 56 forks source link

Item description: When containing macro reference, it blanks the description in the actor sheet #353

Open bakbakbakbakbak opened 1 year ago

bakbakbakbakbak commented 1 year ago

What happened?

  1. Create an ability
  2. Add description to ability, include reference to a macro
  3. Click the ability name in the Abilities tab on a character

What is the expected behaviour?

When I click the name, the description shows, including macro reference, as would be expected compared to other abilities.

However, when re-opening the character sheet, it shows. Indicating that the sheet needs re-rendering when item description is updated.

Relevant Errors and Warnings

No errors, nor warnings.

Additional Support Details

Foundry Virtual Tabletop: Version 10, 10.288 Game System: ose, 1.7.5 Active Modules: 0 Performance Mode: 2

OS: Linux x86_64 Client: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0 GPU: Radeon R9 200 Series Max Texture Size: 16384

No viewed scene

Actors: 1 | Items: 0 | Journal: 0 | Rollable Tables: 0 | Playlists: 0 | Compendium Packs: 0 | Chat Messages: 2

Foundry VTT Core Version

V10

Old-School Essentials Core Version

v1.8.x & v1.7.5

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox, Chrome

Code of Conduct

bakbakbakbakbak commented 1 year ago

@WisdomOfWombats

bakbakbakbakbak commented 1 year ago

Perhaps this from dnd5e/PF2e can be useful for solving this? Specifically as it uses an expanded class on the item, as well as storing the state.

https://github.com/foundryvtt/dnd5e/blob/4de2d2aabb078f0d18a26ea2d94a754ba8d99510/module/applications/actor/base-sheet.mjs#L1194

&

https://github.com/foundryvtt/dnd5e/blob/6f770d1037fe7a164a29242f51babb8e7550fa38/templates/actors/parts/actor-inventory.hbs#L134